Skip to content

Add optional minimum log level to send to client #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add optional minimum log level to send to client #154

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8cbed4
add minimum log level to send to client
joshamb Mar 12, 2024
b12309a
move log comparison to js
joshamb Mar 12, 2024
a47b77b
move minLogLevel into enableServerLogs interface rather than having i…
joshamb Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions priv/static/phoenix_live_reload.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,17 @@ let pageStrategy = channel => {
window[targetWindow].location.reload()
}

const elixirLogLevels = [
"emergency",
"alert",
"critical",
"error",
"warning",
"notice" ,
"info",
"debug"
]

let reloadStrategies = {
css: reloadPageOnCssChanges ? pageStrategy : cssStrategy,
page: pageStrategy
Expand All @@ -51,6 +62,7 @@ class LiveReloader {
constructor(socket){
this.socket = socket
this.logsEnabled = false
this.minLogLevel = "debug"
this.enabledOnce = false
this.editorURL = null
}
Expand All @@ -70,7 +82,7 @@ class LiveReloader {
let reloadStrategy = reloadStrategies[msg.asset_type] || reloadStrategies.page
setTimeout(() => reloadStrategy(this.channel), interval)
})
this.channel.on("log", ({msg, level}) => this.logsEnabled && this.log(level, msg))
this.channel.on("log", ({msg, level}) => this.logsEnabled && this.isMinLogLevel(level) && this.log(level, msg))
this.channel.join().receive("ok", ({editor_url}) => {
this.editorURL = editor_url
})
Expand All @@ -82,9 +94,16 @@ class LiveReloader {
socket.disconnect()
}

enableServerLogs(){ this.logsEnabled = true }
enableServerLogs(level = this.minLogLevel){
this.logsEnabled = true
this.minLogLevel = level
}
disableServerLogs(){ this.logsEnabled = false }

isMinLogLevel(level){
return elixirLogLevels.indexOf(level) <= elixirLogLevels.indexOf(this.minLogLevel)
}

openEditorAtCaller(targetNode){
if(!this.editorURL){
return console.error("phoenix_live_reload cannot openEditorAtCaller without configured PLUG_EDITOR")
Expand Down