-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Correct
:info
flash type styling confusion
Correct the display of `:info` flash messages to be in line with what would be expected from an informational message (blue with "Info" in the title). Before this change, flash messages of kind `:info` would be green and have "Success!" in their title. This is wrong, as success-style feedback should only be shown on clearly successful actions and in cases neutral feedback is needed, success-style feedback does not fit. One example for this is the password reset, when we don't want to disclose whether or not a reset email has been sent. A green "Success!" flash message doesn't fit there. The other way around, a more neutral blue flash message does also fit in situations the user should receive positive feedback. In cases a distinct `:success` flash message kind is needed, it can be added in the project's core components.
- Loading branch information
Showing
3 changed files
with
6 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters