proc: Rename kernel thread to kthread instead of idle #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid confusion when using 'ps' applet DONE: RTOS-845
14 tasks
gerard5
reviewed
Jun 4, 2024
| @@ -1944,7 +1944,7 @@ int proc_threadsList(int n, threadinfo_t *info) | |||
| } | |||
| else { | |||
| map = threads_common.kmap; | |||
| hal_memcpy(info[i].name, "[idle]", sizeof("[idle]")); | |||
| hal_memcpy(info[i].name, "[kthread]", sizeof("[kthread]")); | |||
There was a problem hiding this comment.
Why, kernel threads just can't have its names ? eg. [idle], [klog].
There was a problem hiding this comment.
Threads in general do not have names
There was a problem hiding this comment.
Yes, I see, but asked why, it is (and woud be) a hack anyways.
[kthread] eating 99% of the cpu looks weird (I liked [idle]).
There was a problem hiding this comment.
I get too many question lately "why there're two idle threads on single core system?" :)
This PR is just a proposition, for @Darchiv to decide whether we want this or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid confusion when using 'ps' applet
DONE: RTOS-845
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment