Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel/hal: hal_i2s doesn't display number when zero == 0 and i == 0 #555

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

astalke
Copy link
Contributor

@astalke astalke commented May 29, 2024

Description

  • MISRA
  • Fix hal_i2s not displaying a number when zero == 0 and i == 0

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: ia32-generic-qemu

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@astalke astalke changed the title kernel/hal: hal_i2s doesn't display number when zero==0 and i == 0 kernel/hal: hal_i2s doesn't display number when zero == 0 and i == 0 May 29, 2024
Copy link

Unit Test Results

7 460 tests  ±0   6 745 ✅ ±0   38m 53s ⏱️ -6s
  420 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 1309f46. ± Comparison against base commit 828df3f.

@kemonats
Copy link
Contributor

See #231 proposed over 2 years ago and ignored.

@astalke
Copy link
Contributor Author

astalke commented May 31, 2024

See #231 proposed over 2 years ago and ignored.

I saw your PR, but due to changes in exceptions.c and string.c it doesn't merge, so I wrote it again.

Copy link
Member

@agkaminski agkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants