Fix CI/CD by fixing clippy errors #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clippy complains about these lifetimes as they can be removed by relying on lifetime elision instead. Signed-off-by: Mimoja <[email protected]>
The borrow will be immediately dereferenced by the compiler and is therefore unnecessary. Signed-off-by: Mimoja <[email protected]>
Signed-off-by: Mimoja <[email protected]>
|
Guess not all did show up when running clippy locally. Sorry |
Signed-off-by: Mimoja <[email protected]>
Signed-off-by: Mimoja <[email protected]>
Signed-off-by: Mimoja <[email protected]>
Signed-off-by: Mimoja <[email protected]>
Mimoja
force-pushed
the
master
branch
5 times, most recently
from
55a0562
to
4c191d4
Compare
Signed-off-by: Mimoja <[email protected]>
Mimoja
force-pushed
the
master
branch
5 times, most recently
from
c2709c1
to
9fb12a6
Compare
Signed-off-by: Mimoja <[email protected]>
Mimoja
force-pushed
the
master
branch
3 times, most recently
from
8c0276e
to
2c0707c
Compare
Signed-off-by: Mimoja <[email protected]>
|
I am so very sorry, i played around with the pypi build and forgot i had this PR open. As you are not releasing to PyPi anyways nothing broke, but I will sent a partial revert for my local changes |
|
Addressed in #41 |
This was referenced Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what is needed to make cargo clippy run successfull which should unblock the CI/CD