Add PHP support for TCR #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mengdaming
reviewed
Nov 8, 2023
| mob-timer: | ||
| duration: 5m0s | ||
| tcr: | ||
| language: pho |
There was a problem hiding this comment.
Typo: language should be php
| - os: [windows] | ||
| arch: ["386", amd64, arm64] | ||
| command: .\vendor\bin\phpunit | ||
| arguments: [--list-tests] |
There was a problem hiding this comment.
From I could see, running phpunit --list-tests allows to detect syntax errors in the test files (which is good), but it does not seem to spot syntax error in source files. Do you know of any other php tool that could run syntax check on both src and test files?
There was a problem hiding this comment.
I've just tried an alternative tool to run the syntax check that seems to do the job: php-parallel-lint
When running the command parallel-lint --exclude vendor . I get RC=0 if all src and test files are syntaxically correct, and RC=1 when any of these is not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PHP support for TCR