Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#534): Explicitly define default value for saveLocalCopy #535

Merged
merged 5 commits into from
Sep 30, 2023

Conversation

anlesk
Copy link
Contributor

@anlesk anlesk commented Sep 30, 2023

When GH Action is triggered by cron - it does not respect input's default settings.

fixes #534

@anlesk anlesk changed the title fix(gh-action): Explicitly define default value for saveLocalCopy fix(#534): Explicitly define default value for saveLocalCopy and pre-zip folder Sep 30, 2023
@philosowaffle
Copy link
Owner

@anlesk any more tweaks to this coming or good to merge?

@anlesk
Copy link
Contributor Author

anlesk commented Sep 30, 2023

@philosowaffle sorry, it is not ready yet. I was trying to fix both issues in a single hit, but because GH action runs on docker image that does not have zip installed - the latest addition of pre-zip is failing.
I'll either split in into multiple PRs or fix it within next couple of minutes ;)

@philosowaffle
Copy link
Owner

I've used this action for zip on other workflows, should work here I believe.

@anlesk
Copy link
Contributor Author

anlesk commented Sep 30, 2023

I've used this action for zip on other workflows, should work here I believe.

Interesting.. For some reason, it does not seem to be working as well (https://github.com/anlesk/peloton-to-garmin/actions/runs/6364291199/job/17280467282):

  with:
    files: /app/output/fit
    dest: output.zip
    recursive: true
  env:
    OUTPUT_DIR: /app/output

Ready to zip "/app/output/fit" into output.zip
  - /app/output/fit (Not Found)

Zipped file output.zip successfully

With output.zip being an empty archive file, even though ls -la /app/output/fit clearly shows files in there.

@anlesk anlesk changed the title fix(#534): Explicitly define default value for saveLocalCopy and pre-zip folder fix(#534): Explicitly define default value for saveLocalCopy Sep 30, 2023
@anlesk
Copy link
Contributor Author

anlesk commented Sep 30, 2023

@philosowaffle reverted zip operation back, as it will take more time to fix -- will file new PR.

@philosowaffle
Copy link
Owner

Really odd it doesn't seem to have the same directory context. I guess could always try running apt-get install zip to manually install

@philosowaffle philosowaffle merged commit a8e9fad into philosowaffle:master Sep 30, 2023
2 of 5 checks passed
@anlesk
Copy link
Contributor Author

anlesk commented Sep 30, 2023

Really odd it doesn't seem to have the same directory context. I guess could always try running apt-get install zip to manually install

Yeah, that does the trick:
https://github.com/anlesk/peloton-to-garmin/actions/runs/6364383784/workflow#L99
https://github.com/anlesk/peloton-to-garmin/actions/runs/6364383784

@anlesk anlesk deleted the 534-fix branch September 30, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync workflow fails due to omitted false variable in config json
2 participants