Work around longstanding core Talon issue in which notification windows aren't returned sometimes #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fication windows aren't returned sometimes.
phillco
approved these changes
Jan 23, 2024
|
Yeah, probably! Will do this weekend, just finally had time when this bug exhibited itself to isolate it… |
|
If you do, I usually like to link the bug in the comment (so we can check in the future if we still need the code), but obviously no need to hold this up on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once dynamic lists are a (stable) thing I should rearchitect this so it fetches the actions on demand. But in the meantime this at least helps with a common problem in which Talon can't find any notifications since the NCUI window isn't returned by
ncui.windows().