feat: add meta proto service for service discovery #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 12 | 0 | 0.05s | |
| ✅ CPP | clang-format | 1012 | 3 | 0 | 6.54s |
| ✅ DOCKERFILE | hadolint | 2 | 0 | 0.15s | |
| ✅ JSON | jsonlint | 7 | 0 | 0.2s | |
| ✅ JSON | prettier | 7 | 0 | 0 | 0.74s |
| markdownlint | 6 | 0 | 4 | 1.3s | |
| markdown-link-check | 6 | 1 | 76.82s | ||
| ✅ MARKDOWN | markdown-table-formatter | 6 | 0 | 0 | 0.21s |
| ✅ REPOSITORY | checkov | yes | no | 19.93s | |
| ✅ REPOSITORY | git_diff | yes | no | 0.05s | |
| ✅ REPOSITORY | grype | yes | no | 9.34s | |
| ✅ REPOSITORY | ls-lint | yes | no | 0.07s | |
| ✅ REPOSITORY | secretlint | yes | no | 6.16s | |
| ✅ REPOSITORY | trivy | yes | no | 4.97s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | 0.08s | |
| ✅ REPOSITORY | trufflehog | yes | no | 4.13s | |
| lychee | 140 | 1 | 3.99s | ||
| prettier | 22 | 1 | 1 | 0.83s | |
| ✅ YAML | v8r | 22 | 0 | 9.43s | |
| ✅ YAML | yamllint | 22 | 0 | 0.5s |
See detailed report in MegaLinter reports
MegaLinter is graciously provided by
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
richardapeters
changed the title
| virtual ~ServiceDiscoveryEcho() = default; | ||
|
|
||
| void FindFirstServiceInRange(uint32_t startServiceId, uint32_t endServiceId) override; | ||
| void NotifyServiceChanges(bool value) override |
There was a problem hiding this comment.
[MegaLinter] reported by reviewdog 🐶
Suggested change
| void NotifyServiceChanges(bool value) override | |
| void NotifyServiceChanges(bool value) override |
| } | ||
|
|
||
| protected: | ||
| bool IsProxyServiceSupported(uint32_t& serviceId) const; |
There was a problem hiding this comment.
[MegaLinter] reported by reviewdog 🐶
Suggested change
| bool IsProxyServiceSupported(uint32_t& serviceId) const; | |
| bool IsProxyServiceSupported(uint32_t& serviceId) const; |
| void ServiceDiscoveryEcho::UnregisterObserver(infra::Observer<Service, Echo>* observer) | ||
| { | ||
| services::Echo::UnregisterObserver(observer); | ||
|
|
There was a problem hiding this comment.
[MegaLinter] reported by reviewdog 🐶
Suggested change
|
|
||
| virtual ~ServiceDiscoveryEcho() = default; | ||
|
|
||
| //Implementation of services::ServiceDiscovery |
There was a problem hiding this comment.
[MegaLinter] reported by reviewdog 🐶
Suggested change
| //Implementation of services::ServiceDiscovery | |
| // Implementation of services::ServiceDiscovery |
| void FindFirstServiceInRange(uint32_t startServiceId, uint32_t endServiceId) override; | ||
| void NotifyServiceChanges(bool value) override; | ||
|
|
||
| //Implementation of services::Service |
There was a problem hiding this comment.
[MegaLinter] reported by reviewdog 🐶
Suggested change
| //Implementation of services::Service | |
| // Implementation of services::Service |
| bool AcceptsService(uint32_t id) const override; | ||
| infra::SharedPtr<services::MethodDeserializer> StartMethod(uint32_t serviceId, uint32_t methodId, uint32_t size, const services::EchoErrorPolicy& errorPolicy) override; | ||
|
|
||
| //Implementation of services::Echo |
There was a problem hiding this comment.
[MegaLinter] reported by reviewdog 🐶
Suggested change
| //Implementation of services::Echo | |
| // Implementation of services::Echo |
Comment on lines
59
to
61
| { | ||
| proxy.FindFirstServiceInRange(startServiceId, endServiceId); | ||
| }); |
There was a problem hiding this comment.
[MegaLinter] reported by reviewdog 🐶
Suggested change
| { | |
| proxy.FindFirstServiceInRange(startServiceId, endServiceId); | |
| }); | |
| { | |
| proxy.FindFirstServiceInRange(startServiceId, endServiceId); | |
| }); |
Comment on lines
67
to
69
| { | ||
| proxy.NotifyServiceChanges(allow); | ||
| }); |
There was a problem hiding this comment.
[MegaLinter] reported by reviewdog 🐶
Suggested change
| { | |
| proxy.NotifyServiceChanges(allow); | |
| }); | |
| { | |
| proxy.NotifyServiceChanges(allow); | |
| }); |
| } | ||
| }; | ||
|
|
||
| TEST_F(ServiceDiscoveryTest, return_no_service) |
There was a problem hiding this comment.
[MegaLinter] reported by reviewdog 🐶
Suggested change
| TEST_F(ServiceDiscoveryTest, return_no_service) | |
| TEST_F(ServiceDiscoveryTest, return_no_service) |
| TEST_F(ServiceDiscoveryTest, notify_service_change) | ||
| { | ||
| NotifyServiceChanges(true); | ||
|
|
There was a problem hiding this comment.
[MegaLinter] reported by reviewdog 🐶
Suggested change
| services::ServiceStub service1_{ serviceDiscoveryEcho, 1 }; | ||
| services::ServiceStubProxy service1Proxy{ echo, 1 }; | ||
|
|
||
|
|
There was a problem hiding this comment.
[MegaLinter] reported by reviewdog 🐶
Suggested change
…proto_service_discovery
This commit misses many unit tests!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.