feat: remove logo ids, add sorting alphabetically #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
svensken94
changed the title
|
Thank you very much, good idea, but it would be better to have a separate option, no? So that the new logos appear at the top 🤔 |
|
Yeah, a separate option would be cool, but we don't need ids for items anyway, am I right? |
|
No, it is not really necessary. I started adding ids to each one in case I wanted to create a page to see the data of a specific svg. In the end I think it was not a good idea because in the PRs there were conflicts with the data.ts file jajaja I will probably end up deleting the IDs 😅 |
|
Resolved for the next version of SVGL, it will be available very soon 🚀✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numeric identifiers make no sense once there are randomly generated identifiers. I suggest getting rid of identifiers and sorting logos alphabetically.
The order in the grid now looks more obvious.