Skip to content

Fix tween start delay #7150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix tween start delay #7150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43f5061
Update BaseTween.js
Bambosh May 26, 2025
3fd0923
Use updateStartCountdown
Bambosh May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/tweens/tween/BaseTween.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,13 +548,13 @@ var BaseTween = new Class({
*/
updateStartCountdown: function (delta)
{
this.countdown -= delta;
this.startDelay -= delta;

if (this.countdown <= 0)
if (this.startDelay <= 0)
{
this.hasStarted = true;

this.setActiveState();

this.hasStarted = true;

this.dispatchEvent(Events.TWEEN_START, 'onStart');

Expand Down
12 changes: 1 addition & 11 deletions src/tweens/tween/Tween.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,17 +684,7 @@ var Tween = new Class({
}
else if (!this.hasStarted)
{
this.startDelay -= delta;

if (this.startDelay <= 0)
{
this.hasStarted = true;

this.dispatchEvent(Events.TWEEN_START, 'onStart');

// Reset the delta so we always start progress from zero
delta = 0;
}
delta = this.updateStartCountdown(delta);
}

var stillRunning = false;
Expand Down
12 changes: 1 addition & 11 deletions src/tweens/tween/TweenChain.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,17 +425,7 @@ var TweenChain = new Class({
}
else if (!this.hasStarted)
{
this.startDelay -= delta;

if (this.startDelay <= 0)
{
this.hasStarted = true;

this.dispatchEvent(Events.TWEEN_START, 'onStart');

// Reset the delta so we always start progress from zero
delta = 0;
}
delta = this.updateStartCountdown(delta);
}

var remove = false;
Expand Down