Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading retry improvements #6974

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

pavle-goloskokovic
Copy link
Contributor

This PR improves an existing feature:

  • Implemented retries with exponential backoff which is a technique that retries loading with an exponentially increasing delay time, up to a maximum retry count
  • Increased default maxRetries value to 5, which together with exponential backoff increases possible loading error recovery time to ~3 seconds compared to previous less then 100ms
  • Added FILE_LOAD_RETRY event to Loader Plugin to enable listening to retry occurrences
  • FILE_LOAD_ERROR now also emits Event that resulted form an error as an argument to provide more details to user regarding error cause
  • Moved maxRetries setting from FileConfig to XHRSettingsObject provided to any Loader Plugin method call, to make it possible to override value per file, since there is no way to define properties on fileConfig directly
  • Few other fixes along the way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant