-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component: @phase2/outline-core-breadcrumb
#429
Open
glitchgirl
wants to merge
17
commits into
next
Choose a base branch
from
issue/outline-core-breadcrumb
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d77a784
Merge branch 'next' of https://github.com/phase2/outline into next
glitchgirl cf6bb9f
fix: init and installs
glitchgirl 6fae23d
fix: resize and css
glitchgirl 111bcb1
fix: initial mdx
shaal f7bed0e
fix: simplify storybook markup
shaal df5cb0c
Merge branch 'next' of https://github.com/phase2/outline into issue/o…
glitchgirl 0868eb0
Merge branch 'issue/outline-core-breadcrumb' of https://github.com/ph…
glitchgirl ba5700e
fix: slots
glitchgirl 9bfd022
fix: playing
glitchgirl 0914adc
fix: done except icons
glitchgirl b0cd894
fix: add some icons i want
glitchgirl eb2a478
fix: icons are hard
glitchgirl 439181d
fix: remove icons
glitchgirl ac317a8
Merge branch 'next' of https://github.com/phase2/outline into issue/o…
glitchgirl 01a76b1
fix: merge and node
glitchgirl 74c2dfe
fix: bread
glitchgirl b143475
fix: update style sheets, a11y
glitchgirl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| #!/bin/sh | ||
|
|
||
| if [ "$LEFTHOOK" = "0" ]; then | ||
| exit 0 | ||
| fi | ||
|
|
||
| call_lefthook() | ||
| { | ||
| dir="$(git rev-parse --show-toplevel)" | ||
| osArch=$(uname | tr '[:upper:]' '[:lower:]') | ||
| cpuArch=$(uname -m | sed 's/aarch64/arm64/') | ||
|
|
||
| if lefthook -h >/dev/null 2>&1 | ||
| then | ||
| lefthook "$@" | ||
| elif test -f "$dir/node_modules/lefthook/bin/index.js" | ||
| then | ||
| "$dir/node_modules/lefthook/bin/index.js" "$@" | ||
| elif test -f "$dir/node_modules/@evilmartians/lefthook/bin/lefthook_${osArch}_${cpuArch}/lefthook" | ||
| then | ||
| "$dir/node_modules/@evilmartians/lefthook/bin/lefthook_${osArch}_${cpuArch}/lefthook" "$@" | ||
| elif test -f "$dir/node_modules/@evilmartians/lefthook-installer/bin/lefthook_${osArch}_${cpuArch}/lefthook" | ||
| then | ||
| "$dir/node_modules/@evilmartians/lefthook-installer/bin/lefthook_${osArch}_${cpuArch}/lefthook" "$@" | ||
| elif bundle exec lefthook -h >/dev/null 2>&1 | ||
| then | ||
| bundle exec lefthook "$@" | ||
| elif yarn lefthook -h >/dev/null 2>&1 | ||
| then | ||
| yarn lefthook "$@" | ||
| elif pnpm lefthook -h >/dev/null 2>&1 | ||
| then | ||
| pnpm lefthook "$@" | ||
| elif command -v npx >/dev/null 2>&1 | ||
| then | ||
| npx @evilmartians/lefthook "$@" | ||
| elif swift package plugin lefthook >/dev/null 2>&1 | ||
| then | ||
| swift package --disable-sandbox plugin lefthook "$@" | ||
| else | ||
| echo "Can't find lefthook in PATH" | ||
| fi | ||
| } | ||
|
|
||
| call_lefthook run "pre-commit" "$@" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script's approach to finding and executing
lefthookfrom various possible locations (global, local node_modules, etc.) is comprehensive. However, consider adding a final else clause to exit with a non-zero status code iflefthookcannot be found, to prevent commits from proceeding without passing the hooks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for @himerus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.