Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactor styles.mjs to account for style generation order. #401

Draft
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

bkildow
Copy link
Member

@bkildow bkildow commented Jun 12, 2023

Description

  • Refactors the style generation script to always generate the light dom styles first in case other global styles depend on these (awaits the generations)
  • Gitignores *.scoped.css since this is a generated file

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Visual Testing
  • Automated Testing
  • Accessibility Testing

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Jun 12, 2023

⚠️ No Changeset found

Latest commit: 9deeec9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jun 12, 2023

Deploy Preview for outlinejs ready!

Name Link
🔨 Latest commit 9deeec9
🔍 Latest deploy log https://app.netlify.com/sites/outlinejs/deploys/6487502613386600078c0cd7
😎 Deploy Preview https://deploy-preview-401--outlinejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@socket-security
Copy link

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives1 Size Publisher
glob 🆕 10.2.7 None +16 2.75 MB isaacs

Footnotes

  1. https://docs.socket.dev

@glitchgirl
Copy link
Contributor

TODO:
-discuss applicatiablity to current setup

@himerus himerus added the Held for Review Held for review. Considered as a Draft/POC. label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Held for Review Held for review. Considered as a Draft/POC. Needs: Discussion Severity: Critical
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants