-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP feat/outline-nav-menu #376
base: next
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for outlinejs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
Description
Still WIP but in a reviewable state
Adds:
outline-nav
component and sub-components.Notes:
Can work with:
To test with JSON API:
Spin up a Drupal demo environment and install the JSON:API Menu Item module
Build your menu in
admin/structure/menu/manage/main
Spin up an Outline repo and launch storybook.
Verify the JSON API endpoint is working at
[docksal evntronment]/jsonapi/menu_items/main
(if you're test menu is the main navigation)5 Use chrome Cross Domain CORS extension to allow fetch test
menuEndpoint
in the story and refresh.Still needs:
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist