Skip to content

Improve Stack implementation to dynamically resize #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Alokzh
Copy link
Contributor

@Alokzh Alokzh commented Jul 20, 2025

Changes:

  • This PR fixes the issue of Stack throwing error once it reaches the limit size
  • Now we allocate a new array the double size and copy the elements
  • Added new Tests & improved all other Tests accordingly

@coveralls
Copy link

coveralls commented Jul 20, 2025

Pull Request Test Coverage Report for Build 16395521619

Details

  • 32 of 32 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 16314163840: 0.0%
Covered Lines: 139
Relevant Lines: 139

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 16395521619

Details

  • 32 of 32 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 16314163840: 0.0%
Covered Lines: 139
Relevant Lines: 139

💛 - Coveralls

@jordanmontt
Copy link
Contributor

Great.
@Ducasse with this the stack will double its size, like the ordered collection, when it reaches its full capacity

@jordanmontt jordanmontt merged commit 0e21e4d into pharo-containers:master Jul 23, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants