Refactor configurator #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `register` method was introduced to streamline middleware registration, improving extendability and encapsulation while allowing middlewares like retry and redirect to be added as closures which are lazily invoked during connector configuration. This change leads to cleaner code and a more scalable configuration pattern.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
============================================
+ Coverage 84.61% 84.77% +0.15%
+ Complexity 314 313 -1
============================================
Files 38 38
Lines 728 729 +1
============================================
+ Hits 616 618 +2
+ Misses 112 111 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
registermethod was introduced to streamline middleware registration, improving extendability and encapsulation while allowing middleware to be added as closures which are lazily invoked during connector configuration. This change leads to cleaner code and a more scalable configuration pattern.