CP-17268 debugbar - #2
Merged
Merged
Conversation
…ading superglobals
… the v5 CI extension double-load
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phalcon\Debugexception/error page component (Debug,Dump,ReportBuilder,HtmlRenderer, theReportvalue objects,Contracts, andthe exception classes) out of the framework's
Phalcon\Support\Debug, with itsfull test suite carried over green under PHPStan level max, plus the
debug.css/debug.jspage assets.Providerthat boots the bar against an MVCApplicationpurely through its EventsManager — no DI service and nocontainer-specific wiring — and refuses to boot in blocked/production
environments. It attaches a
ResponseListeneronapplication:beforeSendResponsethat aggregates the collectors and injects thebar into HTML responses, backed by the
DebugBaraggregator and theRenderer/Injector/BarOptionsoutput pipeline.Debugfacade for manual instrumentation —Debug::info(),Debug::debug(),Debug::notice(),Debug::warning(),Debug::error(),Debug::message(),Debug::startMeasure()/Debug::stopMeasure(), andDebug::addException()— that no-ops when no bar is registered.version,messages,time,exceptions,request,route,database,view,cache,config, andsession. Streamedcollectors (database, view, route, cache) read their data off the event source
and never resolve services; snapshot collectors read injected objects
(
request,config) or PHP state (session). Durations are measured withhrtime().Security\Redactorwith two tiers — masking the values of sensitive keys anddropping configured "never shown" keys entirely — applied to the request,
config, and session collectors, plus
Security\AccessGate(IP allowlist andoptional callback) restricting who receives the bar.
redaction (
mask/hidden) configuration on theProvider. The bar shipsunder PHPStan level max with 100% line, method, and class coverage.