impl IntoDatum for Result<T: IntoDatum, E: Display>
#972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s a `Result`. Requires special handling for `Result<Option<T>, E>`.
…<T, E>` such that `E` only needs to be `Display` instead of an actual `std::error::Error`.
This lets functions use `eyre::Result`. For example:
```rust
fn read_file(path: &str) -> eyre::Result<Vec<u8>> {
Ok(std::fs::read(path)?)
}
```
…any()` is not the right way to get the error visible to the user.
…ise the error as it uses the correct `PgSqlErrorCode`
eeeebbbbrrrr
commented
Dec 20, 2022
Contributor
Author
eeeebbbbrrrr
left a comment
eeeebbbbrrrr
left a comment
There was a problem hiding this comment.
I approve of my own changes. I can't see any more tests that need to be added, and everything passes.
This will also cleanup the changeset in #969.
usamoi
pushed a commit
to tensorchord/pgrx
that referenced
this pull request
Mar 6, 2025
…ation#972) This pulls out some commits from pgcentralfoundation#969 into its own PR to add support for `#[pg_extern]`-style functions returning a `Result` of some kind. We don't care about the type of the Error, so long as it implements `Display`. If the returned value is the Err variant, the `IntoDatum` impl for `Result<T, E>` will raise a Postgres ERROR using `ereport!(ERROR, PgSqlErrorCode::ERRCODE_DATA_EXCEPTION, &format!("{}", e))`. It's tested to also work with the [`eyre::Result`](https://docs.rs/eyre/latest/eyre/type.Result.html) type along with returning `Result<Option<T>, E>`. The case of returning a `Result<(), E>` uncovered some issues with how pgx converts `()` into a Datum, so those have been fixed along the way. It also allows `#[pg_test]` functions to return Results which makes writing unit tests a little nicer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls out some commits from #969 into its own PR to add support for
#[pg_extern]-style functions returning aResultof some kind.We don't care about the type of the Error, so long as it implements
Display. If the returned value is the Err variant, theIntoDatumimpl forResult<T, E>will raise a Postgres ERROR usingereport!(ERROR, PgSqlErrorCode::ERRCODE_DATA_EXCEPTION, &format!("{}", e)).It's tested to also work with the
eyre::Resulttype along with returningResult<Option<T>, E>.It also allows
#[pg_test]functions to return Results which makes writing unit tests a little nicer.