-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cargo-pgrx and pgrx-tests on Windows #1934
base: develop
Are you sure you want to change the base?
Conversation
|
43cc5ca
to
e07355c
Compare
It seems that https://patchwork.kernel.org/project/linux-hardening/patch/20180416175918.GA13494@beast/ breaks |
7a70740
to
8befc9f
Compare
The process is explained in the official documentation: https://www.postgresql.org/docs/16/install-windows.html Not a Windows user for years, but can help if you're stuck with something (: |
I'm curious if there are really any Windows developers. So, I'm planning to leave this feature here to see if anyone fixes it. |
👀 reviews? |
Notes:
postgres
directly to starting postgres bypg_ctl
in testingpgrx-cshim.c
is compiled with-flto
: without this flag,pgrx_embed.exe
is linked topostgres.exe
PgLwLock
andPgAtomic
but introduces a breaking change aboutPgLwLock
andPgAtomic
: name must be provided atPgLwLock/PgAtomic::new
,PgLwLock::from_named
is removed and a parameter ofPgLwLock::attach
changescargo pgrx run
andcargo pgrx test
always print logs forpg_ctl start
on Windows (pipes generated bystd::process::Command
are leaked to postgres, a command withStdio::piped()
hangs, so we useStdio::inherit()
on Windows)