Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure bindgen gets the cppflags even if we aren't using macOS #1336

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

thomcc
Copy link
Contributor

@thomcc thomcc commented Oct 12, 2023

I actually didn't realize that we did this correctly anywhere, but it's very dangerous that we don't pass in -DFOOBAR when pg_config says to do that...

If it causes a problem, people can probably use CCC_COMPILE_OPTIONS to work around it

@thomcc thomcc force-pushed the bgen-flags branch 2 times, most recently from 55370eb to 40b6452 Compare October 12, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant