-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] simplify codebase to expose internal API #14
base: master
Are you sure you want to change the base?
Conversation
Work in progress label added. I have to do some heavy profiling before this PR is merged to determine if the new implementation is actually better or worse. The reason is that I refactored the That said, all tests pass, i.e. the behavior is exactly the same, the only difference is that there is an extra function that is created when the consumer chain executes and that could impact rendering time even if the rest of the |
0b21ceb
to
3ec417c
Compare
After a year, I still think this is a valid idea. This PR is something I would like to revisit now that I'm working on version 3. |
- Expose inner functionality `createContextConsumerChain` | ||
### Fixed | ||
### Changed | ||
- Simplify codebase by removing all but one forwardRef |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
definitely not a minor version bump
Checklist
Short description of what this PR does: