Skip conflict-log message assembly when the level is suppressed#492
Conversation
spock_report_conflict() stringified both the local and remote tuples (tuple_to_stringinfo deforms every attribute and calls type-output functions) and did catalog lookups unconditionally, once per conflicting row -- even when the ereport() would be discarded by the active log thresholds. Guard the message assembly with message_level_is_interesting() so a high-conflict apply stream stops paying to format log lines nobody will see. The resolutions-table write above is gated separately and is unaffected.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
2 participants
spock_report_conflict() stringified both the local and remote tuples (tuple_to_stringinfo deforms every attribute and calls type-output functions) and did catalog lookups unconditionally, once per conflicting row -- even when the ereport() would be discarded by the active log thresholds.
Guard the message assembly with message_level_is_interesting() so a high-conflict apply stream stops paying to format log lines nobody will see. The resolutions-table write above is gated separately and is unaffected.