Merged
Conversation
opoplawski
force-pushed
the
feature/dhcp-server
branch
from
3ff166e to
92e2272
Compare
opoplawski
requested changes
Jan 26, 2025
Contributor
opoplawski
left a comment
opoplawski
left a comment
There was a problem hiding this comment.
Thanks for the PR! There are a number of CI fixes to make. Also, please add a changelog fragment.
opoplawski
requested changes
Mar 11, 2025
Contributor
opoplawski
left a comment
opoplawski
left a comment
There was a problem hiding this comment.
It would be good to rebase and squash down your commits as well. Thanks again.
davrosza
force-pushed
the
feature/dhcp-server
branch
from
dc6c515 to
f627703
Compare
Contributor
Author
|
Changes incorporated, git history squashed and rebased. Let me know if there is anything else that should be changed |
opoplawski
approved these changes
Mar 15, 2025
Contributor
opoplawski
left a comment
opoplawski
left a comment
There was a problem hiding this comment.
Seems reasonable for now. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made:
pfsensible_dhcp_server.py, to manage DHCP server settings