[pfsense] handle "."s prefixing php() output

triggered by the presense of /var/run/booting and issue a warning. Fixes #118
pfsensible · Jan 31, 2025 · 763b21a · 763b21a
1 parent eb570cf
commit 763b21a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/changelogs/fragments/booting.yml b/changelogs/fragments/booting.yml
@@ -0,0 +1,2 @@
+bugfixes:
+  - pfsense - handle "."s prefixing php() output triggered by the presense of /var/run/booting and issue a warning (https://github.com/pfsensible/core/issues/118)
diff --git a/plugins/module_utils/pfsense.py b/plugins/module_utils/pfsense.py
@@ -649,6 +649,10 @@ def php(self, command):
         cmd += command
         cmd += '\n?>\n'
         (dummy, stdout, stderr) = self.module.run_command('/usr/local/bin/php', data=cmd)
+        # If /var/run/booting is in place, various requires will emit a "."
+        (stdout, nsubs) = re.subn(r'^\.+', '', stdout)
+        if nsubs > 0:
+            self.module.warn('/var/run/booting appears to be present, confirm successful boot and remove if appropriate.')
         # TODO: check stderr for errors
         return json.loads(stdout)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		bugfixes:
		- pfsense - handle "."s prefixing php() output triggered by the presense of /var/run/booting and issue a warning (https://github.com/pfsensible/core/issues/118)