Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore flake8 E701/704 because it conflicts with recent black #48

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

ktns
Copy link
Contributor

@ktns ktns commented Mar 21, 2024

Due to psf/black#4173, recent black can't be combined with flake8 unless E701 is explicitly disabled.

cf. https://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html#e701-e704

This PR disables flake8 category E701 and E704.

@ktns ktns self-assigned this Mar 21, 2024
Copy link
Member

@linshokaku linshokaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@linshokaku linshokaku merged commit 81cb5ad into pfnet:main Mar 21, 2024
2 checks passed
@ktns ktns deleted the disable_e701_704 branch March 22, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants