Gymnasium support #192
Gymnasium support #192
Conversation
README.md
Outdated
| @@ -30,7 +30,7 @@ Refer to [Installation](http://pfrl.readthedocs.io/en/latest/install.html) for m | |||
|
|
|||
| ## Getting started | |||
|
|
|||
| You can try [PFRL Quickstart Guide](examples/quickstart/quickstart.ipynb) first, or check the [examples](examples) ready for Atari 2600 and Open AI Gym. | |||
| You can try [PFRL Quickstart Guide](examples/quickstart/quickstart.ipynb) first, or check the [examples](examples) ready for Atari 2600 and Open AI gymnasium. | |||
There was a problem hiding this comment.
This should be Farama Foundation's gymnasium
| @@ -4,8 +4,8 @@ | |||
| # Prevent numpy from using multiple threads | |||
| os.environ["OMP_NUM_THREADS"] = "1" | |||
|
|
|||
| import gym # NOQA:E402 | |||
| import gym.wrappers # NOQA:E402 | |||
| import gymnasium # NOQA:E402 | |||
There was a problem hiding this comment.
I'm not familiar with gymnasium much, but is it recommended to write import gymnasium as gym?
Do you know any article about coding convention of gymnasium?
There was a problem hiding this comment.
I'm not sure. The examples they give often write what you have, but I think it's just to sell the simplicity of their transition from gym to gymnasium. I also think the distinction can help for clarity, so people are reminded which API is being used.
There was a problem hiding this comment.
Hmm it does seem even internally in their code they use gym as you say.
There was a problem hiding this comment.
Thanks. Anyway I agree with your opinion:
the distinction can help for clarity
Multiprocess fixes
This Pull request is a work in progress branch for supporting gymnasium in lieu of gym.
Todo/testing items: