-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PPE profiling for S3
#341
Conversation
S3
fc4701b
to
240112a
Compare
240112a
to
f7ea28b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks good. I have one minor suggestion.
pfio/v2/s3.py
Outdated
@@ -380,7 +423,8 @@ def _reset(self): | |||
|
|||
def _connect(self): | |||
# print('boto3.client options:', kwargs) | |||
self.client = boto3.client('s3', **self.kwargs) | |||
obj = boto3.client('s3', **self.kwargs) | |||
self.client = Boto3ProfileWrapper(obj) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to switch here between the vanilla boto3 and the wrapped boto3 client by self.trace
as well as Local
fs does.
Lines 123 to 127 in 9bf5900
# Add ppe recorder to io class methods (e.g. read, write) | |
if self.trace: | |
return LocalProfileIOWrapper(fp) | |
else: | |
return fp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to change from test code ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix and rebase master
branch
f7ea28b
to
47fa284
Compare
PR #343 merge raised a conflict. Could you resolve the conflict before merging this, please? |
Signed-off-by: KantaTamura <[email protected]>
47fa284
to
b43f58d
Compare
This PR resolves the
S3
task in #258Sample program to check tracing
output
rendering of the output json file (trace.json) with chrome://tracing is shown below