Path: more compatibility with pathlib.Path #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhrkw
force-pushed
the
pathlib-compatible
branch
2 times, most recently
from
6a1bf58
to
4f47abd
Compare
yhrkw
force-pushed
the
pathlib-compatible
branch
from
4f47abd
to
e102dc4
Compare
yhrkw
force-pushed
the
pathlib-compatible
branch
from
e102dc4
to
d5be93a
Compare
kuenishi
requested changes
Apr 10, 2024
| return fp.read() | ||
| @classmethod | ||
| def cwd(cls: Type[SelfPathType]) -> SelfPathType: | ||
| raise _not_supported() |
There was a problem hiding this comment.
Some FSes support .cwd including pfio.v2.Local. I want underlying FSes handle this method call (if it doesn't implement cwd, then let it throw unsupported exception. Oh, it has been never implemented. Nevermind..
| fs: FS, | ||
| scheme: Optional[str] = None, | ||
| ) -> None: | ||
| if isinstance(fs, Local): |
There was a problem hiding this comment.
Q: do you @yhrkw have a plan to support custom scheme in near future? Currently, pfio.v2.FS does not have .scheme property, but it'd be worth trying adding the feature to FS class and using it here.
There was a problem hiding this comment.
Yes, I'm currently working on it. I will send a PR after merging this.
kuenishi
approved these changes
Apr 16, 2024
kuenishi
added
the
cat:enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves compatibility between
pfio.v2.pathlib.Pathandpathlib.Path.The key differences between this PR and current impl./
pathlib.Pathas follows.NotImplementedErrorbecause they require unsupported features ofFSschemeproperty foras_uri(will move toFS)as_urireturnsfile,s3,hdfsor custom scheme URI dependent onfsandschemestatreturnspfio.v2.FileStatinstead ofos.stat_result