Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With adding
local_cache=True
keyword to opening a zip FS e.g. usingfrom_url()
, a local cache file is created in a path (by default,~/.cache/pfio/
). The cache file is a named temporary file, but potentially, it can easily be persisted locally. It costs the local disk space, but the amount is just as same as the total amount of data transferred over the network to the client.This will be a major step toward working around #271, as well as improving latency on reading a file from remote file system such as S3.
You can see the difference of space consumed like this:
Concurrency control
pread()
andpwrite()
are thread-safe, other internal data structure such as known ranges is not thread safe. This is future work.pfio.cache.MultiprocessFileCache
can be applied to the classCachedWrapper()
. This is also future work.