Skip to content

✨ NEW: react 19 support #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Make sure you ⭐️ this [`repository`](https://github.com/pettiboy/react-ui-sc

## ✨ Installation

### React 18
### React 19

```bash
npm install --save react-ui-scrollspy
Expand All @@ -31,6 +31,18 @@ OR
yarn add react-ui-scrollspy
```

### React 18

```bash
npm install --save [email protected]
```

OR

```bash
yarn add [email protected]
```

### React 17 and below

```bash
Expand Down
177 changes: 76 additions & 101 deletions demo-app/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions demo-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@
"@testing-library/user-event": "^12.8.3",
"@types/jest": "^26.0.24",
"@types/node": "^12.20.36",
"@types/react": "^17.0.33",
"@types/react-dom": "^17.0.10",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"@types/react": "^19.0.8",
"@types/react-dom": "^19.0.3",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"react-router-dom": "^6.0.2",
"react-scripts": "4.0.3",
"react-ui-scrollspy": "file:react-ui-scrollspy-2.2.0.tgz",
"react-ui-scrollspy": "file:react-ui-scrollspy-2.4.0.tgz",
"typescript": "^4.4.4",
"web-vitals": "^1.1.2"
},
Expand Down
13 changes: 7 additions & 6 deletions demo-app/src/index.tsx
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
import React from "react";
import ReactDOM from "react-dom";
import ReactDOM from "react-dom/client";
import "./index.css";
import App from "./App";
import reportWebVitals from "./reportWebVitals";

ReactDOM.render(
<React.StrictMode>
<App />
</React.StrictMode>,
document.getElementById("root")
const root = ReactDOM.createRoot(document.getElementById("root")!);

root.render(
<React.StrictMode>
<App/>
</React.StrictMode>
);

// If you want to start measuring performance in your app, pass a function
Expand Down
Loading