#226 - Migration from .NET 7.0 to .NET 8.0

.azure/azure-pipelines.yml

@@ -12,9 +12,9 @@ steps:
     displayName: 'docker compose -f ./docker-compose/docker-compose.tests.yml up -d'
 
   - task: UseDotNet@2
-    displayName: 'install .net sdk 7.x'
+    displayName: 'install .net sdk 8.x'
     inputs:
-      version: 7.x
+      version: 8.x
       installationPath: $(Agent.ToolsDirectory)/dotnet
 
   - script: |

.editorconfig

@@ -8,6 +8,7 @@ insert_final_newline = false
 trim_trailing_whitespace = true
 dotnet_diagnostic.SA1000.severity = silent
 dotnet_diagnostic.SA1009.severity = silent
+end_of_line = lf
 
 # Code files
 [*.{cs,csx,vb,vbx}]

.github/workflows/ai_code_reviewer.yml

@@ -0,0 +1,24 @@
+name: AI Code Reviewer
+
+on:
+  pull_request:
+    types:
+      - opened
+      - synchronize
+
+permissions: write-all
+
+jobs:
+  review:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Repo
+        uses: actions/checkout@v3
+
+      - name: AI Code Reviewer
+        uses: freeedcom/ai-codereviewer@main
+        with:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # The GITHUB_TOKEN is there by default so you just need to keep it like it is and not necessarily need to add it as secret as it will throw an error. [More Details](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret)
+          OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
+          OPENAI_API_MODEL: "gpt-4" # Optional: defaults to "gpt-4"
+          exclude: "**/*.json, **/*.md" # Optional: exclude patterns separated by commas

.github/workflows/build_and_test.yml

@@ -21,7 +21,7 @@ jobs:
     - name: Setup .NET
       uses: actions/setup-dotnet@v3
       with:
-        dotnet-version: 7.0.x
+        dotnet-version: 8.0.x
 
     - name: docker compose -f ./docker-compose/docker-compose.tests.yml up -d
       run: docker compose -f ./docker-compose/docker-compose.tests.yml up -d

.github/workflows/build_test_and_publish.yml

@@ -32,7 +32,7 @@ jobs:
     - name: Setup .NET
       uses: actions/setup-dotnet@v3
       with:
-        dotnet-version: 7.0.x
+        dotnet-version: 8.0.x
 
     - name: Setup NuGet
       uses: nuget/setup-nuget@v1

OnlineSales.sln

@@ -34,7 +34,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "workflows", "workflows", "{
 	ProjectSection(SolutionItems) = preProject
 		.github\workflows\build_and_test.yml = .github\workflows\build_and_test.yml
 		.github\workflows\build_test_and_publish.yml = .github\workflows\build_test_and_publish.yml
-		.github\workflows\testreporter.yml = .github\workflows\testreporter.yml
+		.github\workflows\test_reporter.yml = .github\workflows\test_reporter.yml
 	EndProjectSection
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "plugins", "plugins", "{0F2716C8-A043-4743-A8AD-54B86635D567}"
@@ -126,6 +126,6 @@ Global
 		$0.DotNetNamingPolicy = $1
 		$1.DirectoryNamespaceAssociation = PrefixedHierarchical
 		$0.TextStylePolicy = $3
-		version = 1.2.16-pre
+		version = 1.2.19-pre
 	EndGlobalSection
 EndGlobal

plugins/OnlineSales.Plugin.EmailSync/Configuration/AutoMapperProfiles.cs

@@ -12,12 +12,12 @@ public class AutoMapperProfiles : Profile
 {
     public AutoMapperProfiles()
     {
-        this.CreateMap<ImapAccount, ImapAccountCreateDto>().ReverseMap();
-        this.CreateMap<ImapAccount, ImapAccountUpdateDto>()
+        CreateMap<ImapAccount, ImapAccountCreateDto>().ReverseMap();
+        CreateMap<ImapAccount, ImapAccountUpdateDto>()
             .ForAllMembers(m => m.Condition(PropertyNeedsMapping));
-        this.CreateMap<ImapAccountUpdateDto, ImapAccount>()
+        CreateMap<ImapAccountUpdateDto, ImapAccount>()
             .ForAllMembers(m => m.Condition(PropertyNeedsMapping));
-        this.CreateMap<ImapAccount, ImapAccountDetailsDto>();
+        CreateMap<ImapAccount, ImapAccountDetailsDto>();
     }
 
     private static bool PropertyNeedsMapping(object source, object target, object sourceValue, object targetValue)

plugins/OnlineSales.Plugin.EmailSync/Data/EmailSyncDbContext.cs

@@ -7,6 +7,7 @@
 using EntityFrameworkCore.EncryptColumn.Util;
 using Microsoft.EntityFrameworkCore;
 using Microsoft.Extensions.Configuration;
+using Npgsql;
 using OnlineSales.Data;
 using OnlineSales.Interfaces;
 using OnlineSales.Plugin.EmailSync.Entities;
@@ -22,8 +23,8 @@ public EmailSyncDbContext()
     {
     }
 
-    public EmailSyncDbContext(DbContextOptions<PgDbContext> options, IConfiguration configuration, IHttpContextHelper httpContextHelper)
-        : base(options, configuration, httpContextHelper)
+    public EmailSyncDbContext(DbContextOptions<PgDbContext> options, IConfiguration configuration, IHttpContextHelper httpContextHelper, NpgsqlDataSource dataSource)
+        : base(options, configuration, httpContextHelper, dataSource)
     {
         var key = configuration.GetSection("EmailSync:EncryptionKey").Get<string>();
         if (key == null )

plugins/OnlineSales.Plugin.EmailSync/OnlineSales.Plugin.EmailSync.csproj

@@ -1,11 +1,11 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net7.0</TargetFramework>
+    <TargetFramework>net8.0</TargetFramework>
     <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
-    <ReleaseVersion>1.2.16-pre</ReleaseVersion>
+    <ReleaseVersion>1.2.20-pre</ReleaseVersion>
     <EnableDynamicLoading>true</EnableDynamicLoading>
     <Configurations>Debug;Release;Migration</Configurations>
   </PropertyGroup>

plugins/OnlineSales.Plugin.EmailSync/Tasks/EmailSyncTask.cs

@@ -37,21 +37,21 @@ public EmailSyncTask(IConfiguration configuration, EmailSyncDbContext dbContext,
             this.dbContext = dbContext;
             this.domainService = domainService;
 
-            var config = configuration.GetSection(this.configKey)!.Get<TaskWithBatchConfig>();            
+            var config = configuration.GetSection(configKey)!.Get<TaskWithBatchConfig>();            
             if (config is not null)
             {
-                this.batchSize = config.BatchSize;
+                batchSize = config.BatchSize;
             }
             else
             {
-                throw new MissingConfigurationException($"The specified configuration section for the provided configKey {this.configKey} could not be found in the settings file.");
+                throw new MissingConfigurationException($"The specified configuration section for the provided configKey {configKey} could not be found in the settings file.");
             }
 
             var domains = configuration.GetSection("EmailSync:InternalDomains")!.Get<string[]>();
-            this.internalDomains = (domains != null) ? domains : new string[0];
+            internalDomains = (domains != null) ? domains : new string[0];
 
             var ignored = configuration.GetSection("EmailSync:IgnoredEmails")!.Get<string[]>();
-            this.ignoredEmails = (ignored != null) ? ignored : new string[0];
+            ignoredEmails = (ignored != null) ? ignored : new string[0];
         }
 
         public override async Task<bool> Execute(TaskExecutionLog currentJob)

plugins/OnlineSales.Plugin.ReverseProxy/OnlineSales.Plugin.ReverseProxy.csproj

@@ -1,11 +1,11 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net7.0</TargetFramework>
+    <TargetFramework>net8.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
     <Nullable>enable</Nullable>
-    <ReleaseVersion>1.2.16-pre</ReleaseVersion>
+    <ReleaseVersion>1.2.20-pre</ReleaseVersion>
     <Configurations>Release;Debug</Configurations>
   </PropertyGroup>
 

plugins/OnlineSales.Plugin.SendGrid/Data/SendgridDbContext.cs

@@ -4,6 +4,7 @@
 
 using Microsoft.EntityFrameworkCore;
 using Microsoft.Extensions.Configuration;
+using Npgsql;
 using OnlineSales.Data;
 using OnlineSales.Interfaces;
 using OnlineSales.Plugin.SendGrid.Entities;
@@ -17,8 +18,8 @@ public SendgridDbContext()
     {
     }
 
-    public SendgridDbContext(DbContextOptions<PgDbContext> options, IConfiguration configuration, IHttpContextHelper httpContextHelper)
-        : base(options, configuration, httpContextHelper)
+    public SendgridDbContext(DbContextOptions<PgDbContext> options, IConfiguration configuration, IHttpContextHelper httpContextHelper, NpgsqlDataSource dataSource)
+        : base(options, configuration, httpContextHelper, dataSource)
     {
     }
 

plugins/OnlineSales.Plugin.SendGrid/OnlineSales.Plugin.SendGrid.csproj

@@ -1,11 +1,11 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net7.0</TargetFramework>
+    <TargetFramework>net8.0</TargetFramework>
     <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
-    <ReleaseVersion>1.2.16-pre</ReleaseVersion>
+    <ReleaseVersion>1.2.20-pre</ReleaseVersion>
     <EnableDynamicLoading>true</EnableDynamicLoading>
     <Configurations>Debug;Release;Migration</Configurations>
   </PropertyGroup>

plugins/OnlineSales.Plugin.Sms/Data/SmsDbContext.cs

@@ -4,15 +4,16 @@
 
 using Microsoft.EntityFrameworkCore;
 using Microsoft.Extensions.Configuration;
+using Npgsql;
 using OnlineSales.Data;
 using OnlineSales.Plugin.Sms.Entities;
 
 namespace OnlineSales.Plugin.Sms.Data;
 
 public class SmsDbContext : PluginDbContextBase
 {
-    public SmsDbContext(DbContextOptions<PgDbContext> options, IConfiguration configuration, IHttpContextHelper httpContextHelper)
-        : base(options, configuration, httpContextHelper)
+    public SmsDbContext(DbContextOptions<PgDbContext> options, IConfiguration configuration, IHttpContextHelper httpContextHelper, NpgsqlDataSource dataSource)
+        : base(options, configuration, httpContextHelper, dataSource)
     {
     }
 

plugins/OnlineSales.Plugin.Sms/Exceptions/AwsSnsException.cs

@@ -27,10 +27,5 @@ public AwsSnsException(string? message, Exception? innerException)
             : base(message, innerException)
         {
         }
-
-        protected AwsSnsException(SerializationInfo info, StreamingContext context)
-            : base(info, context)
-        {
-        }
     }
 }

plugins/OnlineSales.Plugin.Sms/Exceptions/GetshoutoutException.cs

@@ -22,9 +22,4 @@ public GetshoutoutException(string? message, Exception? innerException)
         : base(message, innerException)
     {
     }
-
-    protected GetshoutoutException(SerializationInfo info, StreamingContext context)
-        : base(info, context)
-    {
-    }
 }

plugins/OnlineSales.Plugin.Sms/Exceptions/NotifyLkException.cs

@@ -22,10 +22,5 @@ public NotifyLkException(string? message, Exception? innerException)
             : base(message, innerException)
         {
         }
-
-        protected NotifyLkException(SerializationInfo info, StreamingContext context)
-            : base(info, context)
-        {
-        }
     }
 }

plugins/OnlineSales.Plugin.Sms/Exceptions/SMSPluginException.cs

@@ -27,10 +27,5 @@ public SmsPluginException(string? message, Exception? innerException)
             : base(message, innerException)
         {
         }
-
-        protected SmsPluginException(SerializationInfo info, StreamingContext context)
-            : base(info, context)
-        {
-        }
     }
 }

plugins/OnlineSales.Plugin.Sms/Exceptions/SmscException.cs

@@ -27,10 +27,5 @@ public SmscException(string? message, Exception? innerException)
             : base(message, innerException)
         {
         }
-
-        protected SmscException(SerializationInfo info, StreamingContext context)
-            : base(info, context)
-        {
-        }
     }
 }

plugins/OnlineSales.Plugin.Sms/Exceptions/TwilioException.cs

@@ -22,10 +22,5 @@ public TwilioException(string? message, Exception? innerException)
             : base(message, innerException)
         {
         }
-
-        protected TwilioException(SerializationInfo info, StreamingContext context)
-            : base(info, context)
-        {
-        }
     }
 }

plugins/OnlineSales.Plugin.Sms/Exceptions/UnknownCountryCodeException.cs

@@ -22,10 +22,5 @@ public UnknownCountryCodeException(string? message, Exception? innerException)
             : base(message, innerException)
         {
         }
-
-        protected UnknownCountryCodeException(SerializationInfo info, StreamingContext context)
-            : base(info, context)
-        {
-        }
     }
 }

plugins/OnlineSales.Plugin.Sms/OnlineSales.Plugin.Sms.csproj

@@ -1,11 +1,11 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net7.0</TargetFramework>
+    <TargetFramework>net8.0</TargetFramework>
     <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
-    <ReleaseVersion>1.2.16-pre</ReleaseVersion>
+    <ReleaseVersion>1.2.20-pre</ReleaseVersion>
     <EnableDynamicLoading>true</EnableDynamicLoading>
     <Configurations>Debug;Release;Migration</Configurations>
   </PropertyGroup>
@@ -27,7 +27,7 @@
     </ProjectReference>
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="AWSSDK.SimpleNotificationService" Version="3.7.300.44" />
+    <PackageReference Include="AWSSDK.SimpleNotificationService" Version="3.7.300.46" />
     <PackageReference Include="libphonenumber-csharp" Version="8.13.29" />
     <PackageReference Include="Twilio" Version="6.16.1" />
     <!-- Insert additional references above this line -->

plugins/OnlineSales.Plugin.Sms/Services/SmscService.cs

@@ -2,12 +2,10 @@
 // Licensed under the MIT license. See LICENSE file in the samples root for full license information.
 // </copyright>
 
-using System.Reflection;
 using System.Web;
 using Newtonsoft.Json;
 using OnlineSales.Plugin.Sms.Configuration;
 using OnlineSales.Plugin.Sms.Exceptions;
-using Serilog;
 
 namespace OnlineSales.Plugin.Sms.Services;
 

plugins/OnlineSales.Plugin.TestPlugin/Data/TestPluginDbContext.cs

@@ -2,10 +2,12 @@
 // Licensed under the MIT license. See LICENSE file in the samples root for full license information.
 // </copyright>
 
+using System.Data.Common;
 using Microsoft.EntityFrameworkCore;
 using Microsoft.EntityFrameworkCore.Infrastructure;
 using Microsoft.EntityFrameworkCore.Migrations;
 using Microsoft.Extensions.Configuration;
+using Npgsql;
 using OnlineSales.Data;
 using OnlineSales.Interfaces;
 using OnlineSales.Plugin.TestPlugin.Entities;
@@ -23,8 +25,8 @@ public TestPluginDbContext()
         migrations = new SortedSet<string>();
     }
 
-    public TestPluginDbContext(DbContextOptions<PgDbContext> options, IConfiguration configuration, IHttpContextHelper httpContextHelper)
-        : base(options, configuration, httpContextHelper)
+    public TestPluginDbContext(DbContextOptions<PgDbContext> options, IConfiguration configuration, IHttpContextHelper httpContextHelper, NpgsqlDataSource dataSource)
+        : base(options, configuration, httpContextHelper, dataSource)
     {
         migrations = new SortedSet<string>(Database.GetPendingMigrations());
     }

plugins/OnlineSales.Plugin.TestPlugin/OnlineSales.Plugin.TestPlugin.csproj

@@ -1,11 +1,11 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net7.0</TargetFramework>
+    <TargetFramework>net8.0</TargetFramework>
     <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
-    <ReleaseVersion>1.2.16-pre</ReleaseVersion>
+    <ReleaseVersion>1.2.20-pre</ReleaseVersion>
     <EnableDynamicLoading>true</EnableDynamicLoading>
     <Configurations>Debug;Release;Migration</Configurations>
   </PropertyGroup>

plugins/OnlineSales.Plugin.Vsto/Data/VstoDbContext.cs

@@ -4,6 +4,7 @@
 
 using Microsoft.EntityFrameworkCore;
 using Microsoft.Extensions.Configuration;
+using Npgsql;
 using OnlineSales.Data;
 using OnlineSales.Plugin.Vsto.Entities;
 
@@ -16,8 +17,8 @@ public VstoDbContext()
     {
     }
 
-    public VstoDbContext(DbContextOptions<PgDbContext> options, IConfiguration configuration, IHttpContextHelper httpContextHelper)
-        : base(options, configuration, httpContextHelper)
+    public VstoDbContext(DbContextOptions<PgDbContext> options, IConfiguration configuration, IHttpContextHelper httpContextHelper, NpgsqlDataSource dataSource)
+        : base(options, configuration, httpContextHelper, dataSource)
     {
     }