Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge BLAST XML tool #105

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

pvanheus
Copy link

As discussed on galaxyproject/tools-iuc#1893 this turns the merge code from the Galaxy BLAST XML datatype into a tool that can merge a list of datasets (or multiple individual datasets) into a single BLAST XML dataset.

@pvanheus
Copy link
Author

BTW this would be made obsolete by galaxyproject/galaxy#5464 if it was achieved.

@peterjc
Copy link
Owner

peterjc commented May 22, 2018

Assuming we later have blastxml2 defined as another datatype, is there anything you'd change now to allow this to merge multiple blastxml files OR multiple blastxml2 files? Or would that be a second tool?

(We would not want to try merging a mixture unless someone produces a robust script to interconvert from one format to the other).

@pvanheus
Copy link
Author

If blastxml2 is similar enough to be merged by the same tool, I think the simplest solution would be to make the format of the input and in the #for loop check that the inputs were consistent in the type being used (i.e. use a combination of #set, #if and $element.ext).

@pvanheus
Copy link
Author

If I read the Travis logs right the error isn't coming from this tool. Am I right?

@peterjc
Copy link
Owner

peterjc commented May 22, 2018

Grr. Another new TravisCI failure, but not your fault:

Applying linter tool_urls... FAIL
.. ERROR: Error '404 Client Error: Not Found for url: http://www.jcvi.org/cms/research/projects/tigrfams/overview/' accessing http://www.jcvi.org/cms/research/projects/tigrfams/overview/

Update: Cross reference d31e21d and https://twitter.com/pjacock/status/998941086168076288

@peterjc
Copy link
Owner

peterjc commented May 22, 2018

The error I am expecting to see is against the Galaxy master branch only,
galaxyproject/galaxy#6180

@pvanheus
Copy link
Author

@peterjc sadly the test against dev failed too - with errors I can't quite make out.

@peterjc
Copy link
Owner

peterjc commented May 24, 2018

Hmm. At the very least there were SQLite locking issues, which seems to be an intermittent problem. I've restarted that test on TravisCI, fingers crossed it gets further.

@peterjc
Copy link
Owner

peterjc commented Jun 12, 2018

The dev branch failed again on re-testing.

In good news, the yarn version issue problem has been fixed on the Galaxy master branch, so I've asked TravisCI to retest that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants