Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve animation issues with Date picker #75

Closed
wants to merge 6 commits into from

Commits on Dec 8, 2021

  1. Configuration menu
    Copy the full SHA
    7443a6f View commit details
    Browse the repository at this point in the history
  2. Refactored Toggle and Date Time pickers from ReminderDetailsView into…

    … a new view; ReminderDateTimeView, and passed viewModel via the environment.
    disc0infern0 committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    2c59e13 View commit details
    Browse the repository at this point in the history
  3. ReminderDetailsViewModel: Bug fix for setPickerState. Added withOptio…

    …nalAnimation to honour Accessibility setting
    disc0infern0 committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    f689317 View commit details
    Browse the repository at this point in the history
  4. Refactored date/time pickers to new view and updated control of state…

    … with new enum, allowing animations of picker view transitions to be handled precisely with new function setPickerState.
    
    No settings for transitions or animations work well (in a Form) when transitioning from a state where the date picker is shown, so use the setPickerState function to make transitions from a date picker shown state without animation, but animate all other view transitions.
    There is now no janky animation whatsoever, but 2 out of the 6 possible transitions now happen without animation.
    disc0infern0 committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    c4d9ede View commit details
    Browse the repository at this point in the history
  5. Updated code in ReminderDetailsViewModel.swift to satisfy Egyptian ty…

    …pe if else formatting. Updated one instance of newvalue to newValue.
    disc0infern0 committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    cfa4c7b View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2021

  1. ReminderListViewModel.

    Removed unused Date functions and repositioned to end of file with additional commentary.
    Moved definition of enum for PickerState into the class.
    
    RemindersListViewModel.swift:
    Removed unneeded delay in combine pipeline for removing blank entries.
    disc0infern0 committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    8a59be3 View commit details
    Browse the repository at this point in the history