-
Notifications
You must be signed in to change notification settings - Fork 5
fix: Add macOS platform support via Chameleon typealias pattern #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
doozMen
wants to merge
2
commits into
peterfriese:main
Choose a base branch
from
doozMen:fix/macos-platform-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| // | ||
| // PlatformTypes.swift | ||
| // ConversationKit | ||
| // | ||
| // Cross-platform type aliases following the Chameleon pattern: | ||
| // centralize platform differences so view code stays clean. | ||
|
|
||
| import SwiftUI | ||
|
|
||
| #if canImport(UIKit) | ||
| import UIKit | ||
| public typealias PlatformImage = UIImage | ||
| #elseif canImport(AppKit) | ||
| import AppKit | ||
| public typealias PlatformImage = NSImage | ||
| #endif | ||
|
|
||
| // MARK: - Platform Image Construction | ||
|
|
||
| extension PlatformImage { | ||
| /// Create a platform image from an SF Symbol name. | ||
| static func systemSymbol(_ name: String) -> PlatformImage? { | ||
| #if canImport(UIKit) | ||
| return UIImage(systemName: name) | ||
| #elseif canImport(AppKit) | ||
| return NSImage(systemSymbolName: name, accessibilityDescription: nil) | ||
| #endif | ||
| } | ||
| } | ||
|
|
||
| // MARK: - Platform Image → SwiftUI Image | ||
|
|
||
| extension Image { | ||
| /// Create a SwiftUI Image from a platform-native image. | ||
| init(platformImage: PlatformImage) { | ||
| #if canImport(UIKit) | ||
| self.init(uiImage: platformImage) | ||
| #elseif canImport(AppKit) | ||
| self.init(nsImage: platformImage) | ||
| #endif | ||
| } | ||
| } | ||
|
|
||
| // MARK: - Platform Colors | ||
|
|
||
| extension Color { | ||
| /// Secondary system background — `.secondarySystemBackground` on iOS, | ||
| /// `.controlBackgroundColor` on macOS. | ||
| static var platformSecondaryBackground: Color { | ||
| #if canImport(UIKit) | ||
| Color(uiColor: .secondarySystemBackground) | ||
| #elseif canImport(AppKit) | ||
| Color(nsColor: .controlBackgroundColor) | ||
| #endif | ||
| } | ||
|
|
||
| /// System gray 4 — `.systemGray4` on iOS, `.systemGray` on macOS. | ||
| static var platformGray4: Color { | ||
| #if canImport(UIKit) | ||
| Color(uiColor: .systemGray4) | ||
| #elseif canImport(AppKit) | ||
| Color(nsColor: .systemGray) | ||
| #endif | ||
| } | ||
|
|
||
| /// Separator color — `.separator` on iOS, `.separatorColor` on macOS. | ||
| static var platformSeparator: Color { | ||
| #if canImport(UIKit) | ||
| Color(uiColor: .separator) | ||
| #elseif canImport(AppKit) | ||
| Color(nsColor: .separatorColor) | ||
| #endif | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "path(in rect: CGRect)" method in the "RoundedCorner" shape is quite verbose due to the repeated "addLine" and "addArc" calls for each corner. While functional, encapsulating the logic for adding a single rounded corner segment could improve readability and reduce repetition, making the code easier to maintain in the long run.