A few tiny changes for C++23—friendliness #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change was made in response to a GCC-14.2.1 warning:
a comparison operator in the form `bool T::operator==(const U&)` (note that the function itself is not const)
expects the left operand to be non-const, but as of C++20 can be "reversed" - so that `T{} == U{}` and `U{} == T{}`
may refer to the same operator overload.
Apparently this may break things.
Regardless of the details regarding this warning, it only makes sense for stdex::cbitset::operator== to allow const
operands on both sides, and it is likely the intended behavior.
…ctor
With GCC-14.2.1, compiling with `-std=c++23`: the expression `T{}` seems to expect an explicit default constructor
if T (only) has deleted copy-constructors and defaulted move-constructors.
peter-winter
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently tried to use
ctpgfor a tiny program of mine, which is written in C++23 - it failed to compile due to an operator overload (see 67be52d), and a test failed to compile (see 4ccc849) after that.I tried to justify the changes within the commit messages, however I'm not entirely sure why those problems weren't problems before my latest system update (especially the second one I fixed).