Prevent homebrew resolution #3083
Merged
+18
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents `find_program`/etc. from resolving system dependencies in the homebrew directory and implicitly picking up dependencies we intend to vendor. We were experiencing missing symbol errors after homebrew upgraded the Abseil LTS a few months back, which was implicitly pulled in by libprotobuf's `CMakeLists.txt` using `find_package`. This forces libprotobuf to failover to vendoring the abseil build and pulling in the correct headers. Signed-off-by: Timothy Bess <[email protected]>
timbess
force-pushed
the
bugfix/implicit-system-absl-usage
branch
from
737265b to
2cd998c
Compare
timbess
force-pushed
the
bugfix/implicit-system-absl-usage
branch
4 times, most recently
from
f436180 to
77b60b5
Compare
Signed-off-by: Andrew Stein <[email protected]>
timbess
force-pushed
the
bugfix/implicit-system-absl-usage
branch
from
77b60b5 to
4fddc55
Compare
texodus
approved these changes
Nov 10, 2025
Member
texodus
left a comment
texodus
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents
find_program/etc. from resolving system dependencies in the homebrew directory and implicitly picking up dependencies we intend to vendor. We were experiencing missing symbol errors after homebrew upgraded the Abseil LTS a few months back, which was implicitly pulled in by libprotobuf'sCMakeLists.txtusingfind_package. This forces libprotobuf to failover to vendoring the abseil build and pulling in the correct headers.Pull Request Checklist
Discussions, this PR applies to.