Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: For 1.8: Feature 119 #120

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Conversation

shimono
Copy link
Member

@shimono shimono commented Nov 4, 2019

No description provided.

@shimono shimono requested review from dixonsiu and tochi-y November 4, 2019 09:58
@shimono shimono self-assigned this Nov 4, 2019
src/main/resources/js-lib/personium-dao.js Outdated Show resolved Hide resolved
@tochi-y tochi-y self-requested a review November 5, 2019 05:44
Copy link
Member

@tochi-y tochi-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed a operation. Request changes is correct.

put should accept both if-match and if-none-match headers in the future, so renamed the param key of __put from etag to ifMatch for its preparation.
add comments.
@shimono shimono requested a review from tochi-y November 7, 2019 03:17
@shimono shimono changed the title Feature 119 For 1.8: Feature 119 Dec 2, 2019
@shimono shimono changed the title For 1.8: Feature 119 WIP: For 1.8: Feature 119 Dec 4, 2019
@shimono shimono added this to the next_candidate milestone Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants