Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHORES: Add additional procedures #7

Merged
merged 6 commits into from
Jul 27, 2020
Merged

CHORES: Add additional procedures #7

merged 6 commits into from
Jul 27, 2020
+82 −21

Conversation

dixonsiu
Copy link
Member

@dixonsiu dixonsiu commented Jul 26, 2020 •
edited
Loading

Closes #3, #6

Dixon Siu added 5 commits July 24, 2020 09:46
CHORES: Add procedures to configure WSL 2

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
53ec9b9 
Closes personium#4.
CHORES: Add URLs and use proper naming
335f511
CHORES: Add descriptions and revised procedures
4967408 
1. add "-d" option to "docker-compose up"
2. add setup procedures (upload file, bash prompt) for Windows 10 user
CHORES: Rearrange descriptions
2288116
CHORES: Add procedures to clean up environment
71f9ec6
@dixonsiu dixonsiu added the documentation Improvements or additions to documentation label Jul 26, 2020
@dixonsiu dixonsiu self-assigned this Jul 26, 2020
yoh1496
yoh1496 approved these changes Jul 26, 2020
View reviewed changes
Copy link
Contributor

@yoh1496 yoh1496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks dixon for writing more detailed instruction for using personium-docker

I approve it (there are some suggestions.)

@dixonsiu dixonsiu merged commit f48d36e into personium:master Jul 27, 2020
@dixonsiu dixonsiu deleted the procedures4windows10 branch July 27, 2020 05:02
@dixonsiu dixonsiu mentioned this pull request Jul 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoh1496 yoh1496

@j1n6 j1n6

@mathminds mathminds

@tochi-y tochi-y

Assignees

@dixonsiu dixonsiu

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usage section does not have enough description for user to continue
2 participants
@dixonsiu @yoh1496