Fix PostgreSQL column name case sensitivity in WHERE clauses#574
Open
wazum wants to merge 1 commit intoperftools:0.24.xfrom
Open
Fix PostgreSQL column name case sensitivity in WHERE clauses#574wazum wants to merge 1 commit intoperftools:0.24.xfrom
wazum wants to merge 1 commit intoperftools:0.24.xfrom
Conversation
PostgreSQL treats unquoted identifiers as lowercase, but the xhgui schema creates columns with specific case (e.g., SERVER in uppercase). This causes SQL errors when filtering results: SQLSTATE[42703]: Undefined column: column "server" does not exist This commit quotes all column names in WHERE clauses to preserve their case, ensuring PostgreSQL uses the exact column names as defined in the schema. The fix is compatible with both PostgreSQL and MySQL databases. Affected columns: - simple_url - request_date - request_ts - SERVER (for remote_addr, cookie, and server_name filters) Fixes the "Slim Application Error" when viewing traces in xhgui with PostgreSQL backends. Resolves perftools#573
lauripiisang
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL treats unquoted identifiers as lowercase, but the xhgui schema creates columns with specific case (e.g.,
SERVERin uppercase). This causes SQL errors when filtering results:This commit quotes all column names in
WHEREclauses to preserve their case, ensuring PostgreSQL uses the exact column names as defined in the schema. The fix is compatible with both PostgreSQL and MySQL databases (relies on the already setSQL_MODE=ANSI_QUOTES).Affected columns:
simple_urlrequest_daterequest_tsSERVER(for remote_addr, cookie, and server_name filters)Fixes the "Slim Application Error" when viewing traces in xhgui with PostgreSQL backends.
Resolves #573