Tidy sanitizers' suppressions list and fix some mem leaks #438
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #438 +/- ##
====================================================
Coverage ? 84.73%
====================================================
Files ? 21
Lines ? 2634
Branches ? 413
====================================================
Hits ? 2232
Misses ? 321
Partials ? 81
🚀 New features to boost your workflow:
|
dAdAbird
force-pushed
the
cio-cio-asan
branch
6 times, most recently
from
3c5511d to
e8c9ac0
Compare
Tihs PR makes a suppression list as specific as possible, so it won't cover up new issues. And adds comments to existing suppressions. Also, fixes memory leaks in pg_tde code (all related to frontend usage).
| @@ -562,6 +562,51 @@ check_provider_record(KeyringProviderRecord *provider_record) | |||
|
|
|||
| #endif /* !FRONTEND */ | |||
|
|
|||
| void | |||
There was a problem hiding this comment.
I think we need to decide whether we like the "register key provider" stuff. If we do then each key provider type needs to be responsible for how to free their own specific version of GenericKeyring.
If we don't, we need to remove it.
Doing it both ways is just messy. I know this function wouldn't be the only place that ignores the register key provider functionality, but we need to make a decision whether we want to keep it or not before adding more code that ignores it imho.
Tihs PR makes a suppression list as specific as possible, so it won't cover up new issues. And adds comments to existing suppressions. Also, fixes memory leaks in bin/pgctl code (all related to frontend usage) and low-hanging fruits in pgctl.