Simplify the logic for looking up provider and principal key in pg_tde_set_*_key_using_*_key_provider()
#274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve readability for the provider vs key type logic.
This enum was only used in one place and oscured the two dimensions of provider types (database vs global) and principal keys (server vs default vs database).
Make the intent a lot cleaner by doing the check when a global provider us used instead of deciding to do it or not per user facing function.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (78.23%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #274 +/- ##
=====================================================
- Coverage 78.34% 78.23% -0.11%
=====================================================
Files 22 22
Lines 2484 2472 -12
Branches 391 387 -4
=====================================================
- Hits 1946 1934 -12
Misses 462 462
Partials 76 76
🚀 New features to boost your workflow:
|
jeltz
changed the title
pg_tde_set_*_key_using_*_key_provider()pg_tde_set_*_key_using_*_key_provider()
dutow
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
global_statusenum was only used in one place and obscured the two dimensions of provider types (database vs global) and principal keys (server vs default vs database).Also make the current intent of the superuser check clearer by moving it into the internal function and checking for superuser depending on if we try to access a global key provider or not.