Skip to content

Conversation

@jeltz
Copy link
Collaborator

@jeltz jeltz commented Apr 25, 2025

While these tests test our changes to pg_waldump they are quite easy to overlook right now and where exactly should we draw the line? These tests are not something we ever want to upstream and in the future when we figure out how we want to make sure pg_waldump works with encrypted WAL we likely will want to have the tests for that solution in the same folder as our other tests anyway.

@jeltz jeltz requested review from dAdAbird and dutow as code owners April 25, 2025 22:40
@jeltz jeltz force-pushed the tde/mv-pg_waldump-tests branch from 821fa49 to d3f851a Compare April 25, 2025 22:41
While these tests test our changes to pg_waldump they are quite easy to
overlook right now and where exactly should we draw the line? These
tests are not something we ever want to upstream and in the future when
we figure out how we want to make sure pg_waldump works with encrypted
WAL we likely will want to have the tests for that solution in the same
folder as our other tests anyway.
@jeltz jeltz force-pushed the tde/mv-pg_waldump-tests branch from d3f851a to 796ff9a Compare April 25, 2025 22:53
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.38%. Comparing base (e355f38) to head (796ff9a).

❌ Your project status has failed because the head coverage (78.38%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           TDE_REL_17_STABLE     #269      +/-   ##
=====================================================
+ Coverage              78.34%   78.38%   +0.04%     
=====================================================
  Files                     22       22              
  Lines                   2484     2484              
  Branches                 391      391              
=====================================================
+ Hits                    1946     1947       +1     
  Misses                   462      462              
+ Partials                  76       75       -1     
Components Coverage Δ
access 79.35% <ø> (ø)
catalog 86.23% <ø> (ø)
common 92.50% <ø> (ø)
encryption 71.90% <ø> (ø)
keyring 72.07% <ø> (ø)
src 54.12% <ø> (+0.33%) ⬆️
smgr 98.01% <ø> (ø)
transam ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeltz jeltz merged commit 23786e9 into percona:TDE_REL_17_STABLE Apr 28, 2025
15 checks passed
@jeltz jeltz deleted the tde/mv-pg_waldump-tests branch April 28, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants