Skip to content

Pg 1545 Update test case to cover grant grant management to role scenario #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: TDE_REL_17_STABLE
Choose a base branch
from

Conversation

shahidullah79
Copy link
Collaborator

Update the existing test case to cover this scenario.

@shahidullah79 shahidullah79 requested review from jeltz and removed request for dAdAbird April 18, 2025 19:09
Copy link
Collaborator

@jeltz jeltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather having a meaningful test and also run the revoke at the same time.

@shahidullah79
Copy link
Collaborator Author

I would rather having a meaningful test and also run the revoke at the same time.

I agree, but we are currently facing an issue with this function, pg1546, which is preventing us from testing the exact behavior of this and the revoke functions. For now, I've just added a test case to cover the pg1545 scenario

@jeltz
Copy link
Collaborator

jeltz commented Apr 25, 2025

Oh right, but since we may want to remove these functions I am not sure I see the value of this test. Why not just rip them out? @dutow what do you think? You like I was opposed to using SECURITY DEFINER, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants