Skip to content

PMM-13463 Grafana 11.6.0#3838

Merged
matejkubinec merged 28 commits intov3from
PMM-13463
May 14, 2025
Merged

PMM-13463 Grafana 11.6.0#3838
matejkubinec merged 28 commits intov3from
PMM-13463

Conversation

@matejkubinec
Copy link
Copy Markdown
Contributor

@matejkubinec matejkubinec commented Mar 27, 2025

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 19.35484% with 25 lines in your changes missing coverage. Please review.

Project coverage is 43.65%. Comparing base (243f892) to head (9add3a6).
Report is 1 commits behind head on v3.

Files with missing lines Patch % Lines
managed/services/user/user.go 0.00% 11 Missing ⚠️
managed/services/grafana/client.go 42.85% 8 Missing ⚠️
managed/models/user_flags_model_reform.go 0.00% 3 Missing ⚠️
managed/services/dump/dump.go 0.00% 2 Missing ⚠️
managed/services/management/dump/dump.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #3838      +/-   ##
==========================================
- Coverage   43.70%   43.65%   -0.06%     
==========================================
  Files         369      369              
  Lines       45213    45165      -48     
==========================================
- Hits        19762    19717      -45     
- Misses      23739    23743       +4     
+ Partials     1712     1705       -7     
Flag Coverage Δ
admin 11.44% <ø> (-0.05%) ⬇️
agent 52.61% <ø> (-0.13%) ⬇️
managed 45.04% <19.35%> (-0.03%) ⬇️
vmproxy 73.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matejkubinec matejkubinec marked this pull request as ready for review April 10, 2025 10:48
@matejkubinec matejkubinec requested a review from a team as a code owner April 10, 2025 10:48
@matejkubinec matejkubinec requested review from BupycHuk and idoqo and removed request for a team April 10, 2025 10:48
@ademidoff ademidoff changed the title PMM-13463 Grafana 11.5.3 PMM-13463 Grafana 11.6.0 Apr 10, 2025
Comment thread managed/services/grafana/client.go Outdated
@matejkubinec matejkubinec requested a review from ademidoff April 10, 2025 11:36
@matejkubinec matejkubinec requested a review from a team as a code owner April 10, 2025 14:47
@matejkubinec matejkubinec requested review from ioana-maniga and removed request for a team April 10, 2025 14:47
Comment thread build/ansible/roles/grafana/files/grafana.ini Outdated
@ademidoff ademidoff requested review from BupycHuk and JiriCtvrtka May 12, 2025 07:02
Comment thread ui/docker-compose.yml
#- '../../grafana/conf/grafana.local-dev.ini:/usr/share/grafana/conf/defaults.ini'
environment:
- PMM_DEBUG=1
- GF_DEFAULT_APP_MODE=development
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this leftover from development? Or is it needed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just used during PMM UI development, replaces mounting a custom grafana config (GF_DEFAULT_APP_MODE=development enables loading of new grafana FE code).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks.

@matejkubinec matejkubinec merged commit 932484e into v3 May 14, 2025
24 checks passed
@matejkubinec matejkubinec deleted the PMM-13463 branch May 14, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants