Docs: update public-address page #3570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like this link leads nowhere other than the page itself, which duplicates the [Public address] section. Apart from that, the way it's rendered on the page feels broken.
ademidoff
requested review from
BupycHuk,
idoqo and
JiriCtvrtka
and removed request for
a team
ademidoff
temporarily deployed
to
doc-fix-public-address - pmm-doc-3 PR #3570
Render
Destroyed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #3570 +/- ##
=====================================
Coverage ? 43.63%
=====================================
Files ? 366
Lines ? 44311
Branches ? 0
=====================================
Hits ? 19334
Misses ? 23294
Partials ? 1683
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BupycHuk
approved these changes
Feb 4, 2025
catalinaadam
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like this link leads nowhere other than the page itself, which duplicates the [Public address] section.
Apart from that, the way it's rendered on the page feels broken:
This PR also fixes the wrong port mappings in a few places.