Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json syntax #99

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Fix json syntax #99

merged 1 commit into from
Jan 18, 2024

Conversation

artemgavrilov
Copy link
Collaborator

JSON format requires double quotes and last element should not end with a comma
https://www.json.org/json-en.html

A string is a sequence of zero or more Unicode characters, wrapped in double quotes, using backslash escapes.

@artemgavrilov artemgavrilov changed the title Fix json syntax (replace single quotes with double) Fix json syntax Jan 15, 2024
Copy link

Performance test results:
Normal queries: 9355
TDE queries: 8377
Percentage: 89%

@artemgavrilov artemgavrilov marked this pull request as ready for review January 15, 2024 15:17
@artemgavrilov artemgavrilov requested review from dAdAbird, nastena1606 and dutow and removed request for dAdAbird and nastena1606 January 15, 2024 15:18
Copy link
Collaborator

@nastena1606 nastena1606 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@artemgavrilov artemgavrilov merged commit 37880fd into main Jan 18, 2024
5 checks passed
@artemgavrilov artemgavrilov deleted the fix-json-syntax branch January 18, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants