PG-1095 Add format validation CI workflow and format sources #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Performance test results: |
artemgavrilov
force-pushed
the
PG-1095-check-workflow
branch
from
03c7998
to
5cd9794
Compare
artemgavrilov
changed the title
artemgavrilov
requested review from
dutow,
dAdAbird and
codeforall
and removed request for
dutow and
dAdAbird
artemgavrilov
changed the title
artemgavrilov
commented
Oct 11, 2024
artemgavrilov
commented
Oct 11, 2024
artemgavrilov
commented
Oct 11, 2024
artemgavrilov
force-pushed
the
PG-1095-check-workflow
branch
from
47a1d23
to
f2e1990
Compare
artemgavrilov
changed the title
dutow
requested changes
Oct 12, 2024
There was a problem hiding this comment.
Generally looks good, but please exclude the versioned folders (src16, src17, and later any srcXX) from it.
The idea of them is that they only do minimal changes to the files copied from the server, to ensure that we can do minor/major version updates in an automated way using scripts.
Reformatting them would break this workflow.
If some lines/sections are completely added by us, reformatting them is okay, but this should be a manual process, not automated, because of the majority of the changes are done by sed. (the script doing this is in the tools directory)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PG-1095
This PR adds code format check job. Also it added Makefile target for code formatting according to PG style (pgindent)
License header check and cppcheck will be added in separate PR.