PG-1072: Fix major event trigger issues #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dutow
commented
Oct 9, 2024
dutow
commented
- Create table always checked the principal key and tried to create it, event when we didn't try to create a tde_heap table
- Alter table wasn't handled, and because of this changing a table to tde_heap access method didn't result in an encrypted table.
- defaut_table_access_method wasn't handled, and because of this, creating a table using that also resulted in a non encrypted table.
dAdAbird
approved these changes
Oct 9, 2024
src/pg_tde_event_capture.c
Outdated
Comment on lines
136
to
137
| fprintf(stderr, "ALTEEEER\n"); | ||
| fprintf(stderr, "ALTEEEER\n"); |
src/pg_tde_event_capture.c
Outdated
| { | ||
| AlterTableCmd *cmd = (AlterTableCmd *) lfirst(lcmd); | ||
| if(cmd->subtype == AT_SetAccessMethod && strcmp(cmd->name, "tde_heap")==0) { | ||
| fprintf(stderr, "TO ENCRYPTED\n"); |
* Create table always checked the principal key and tried to create it, event when we didn't try to create a tde_heap table * Alter table wasn't handled, and because of this changing a table to tde_heap access method didn't result in an encrypted table. * defaut_table_access_method wasn't handled, and because of this, creating a table using that also resulted in a non encrypted table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.