Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some compiler warnings #304

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Fix some compiler warnings #304

merged 1 commit into from
Oct 11, 2024

Conversation

artemgavrilov
Copy link
Collaborator

@artemgavrilov artemgavrilov commented Oct 8, 2024 •
edited
Loading

  1. address of array 'vaultV2_keyring->vault_mount_path' will always evaluate to 'true' [-Wpointer-bool-conversion]
  2. format specifies type 'long' but the argument has type 'off_t' (aka 'long long') [-Wformat]
  3. no previous prototype for function 'get_principal_key_from_keyring' [-Wmissing-prototypes]
  4. mixing declarations and code is incompatible with standards before C99 [-Wdeclaration-after-statement]

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

Performance test results:
Normal queries: 9248
TDE queries: 8826
Percentage: 95%

@artemgavrilov artemgavrilov marked this pull request as ready for review October 9, 2024 15:31
@artemgavrilov artemgavrilov merged commit 38f6e5c into main Oct 11, 2024
14 checks passed
@artemgavrilov artemgavrilov deleted the fix-some-warnings branch October 11, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dAdAbird dAdAbird dAdAbird approved these changes

@dutow dutow Awaiting requested review from dutow

@codeforall codeforall Awaiting requested review from codeforall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artemgavrilov @dAdAbird